Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 985063002: Pass in the origin when closing a persistent notification. (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Pass in the origin when closing a persistent notification. This is part of a three-sided patch: [1] https://codereview.chromium.org/982313002/ [2] This patch. [3] https://codereview.chromium.org/985693004/ BUG=447628 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191699

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/modules/notifications/Notification.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Peter Beverloo
PTAL :)
5 years, 9 months ago (2015-03-06 15:53:21 UTC) #2
Mike West
lgtm
5 years, 9 months ago (2015-03-06 16:12:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985063002/20001
5 years, 9 months ago (2015-03-11 11:32:35 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 12:53:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191699

Powered by Google App Engine
This is Rietveld 408576698