Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: content/browser/service_worker/service_worker_cache.h

Issue 985053002: [ServiceWorkerCache] Cache and CacheStorage creation UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Also monitor cache storage creation Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_cache.h
diff --git a/content/browser/service_worker/service_worker_cache.h b/content/browser/service_worker/service_worker_cache.h
index a12a324c9c09ad6a0193742ce517dd4fd4cfd3ff..5952c33c00e02bf33cd8e66a65ad129a5e089c56 100644
--- a/content/browser/service_worker/service_worker_cache.h
+++ b/content/browser/service_worker/service_worker_cache.h
@@ -40,11 +40,14 @@ class TestServiceWorkerCache;
class CONTENT_EXPORT ServiceWorkerCache
: public base::RefCounted<ServiceWorkerCache> {
public:
+ // This enum is used in histograms, so do not change the ordering and always
+ // append new types to the end.
enum ErrorType {
- ErrorTypeOK = 0,
- ErrorTypeExists,
- ErrorTypeStorage,
- ErrorTypeNotFound
+ ERROR_TYPE_OK = 0,
+ ERROR_TYPE_EXISTS,
+ ERROR_TYPE_STORAGE,
+ ERROR_TYPE_NOT_FOUND,
+ ERROR_TYPE_LAST = ERROR_TYPE_NOT_FOUND
};
enum EntryIndex { INDEX_HEADERS = 0, INDEX_RESPONSE_BODY };
@@ -69,19 +72,19 @@ class CONTENT_EXPORT ServiceWorkerCache
const scoped_refptr<storage::QuotaManagerProxy>& quota_manager_proxy,
base::WeakPtr<storage::BlobStorageContext> blob_context);
- // Returns ErrorTypeNotFound if not found.
+ // Returns ERROR_TYPE_NOT_FOUND if not found.
void Match(scoped_ptr<ServiceWorkerFetchRequest> request,
const ResponseCallback& callback);
// Puts the request and response object in the cache. The response body (if
// present) is stored in the cache, but not the request body. Returns
- // ErrorTypeOK on success.
+ // ERROR_TYPE_OK on success.
void Put(scoped_ptr<ServiceWorkerFetchRequest> request,
scoped_ptr<ServiceWorkerResponse> response,
const ResponseCallback& callback);
// Returns ErrorNotFound if not found. Otherwise deletes and returns
- // ErrorTypeOK.
+ // ERROR_TYPE_OK.
void Delete(scoped_ptr<ServiceWorkerFetchRequest> request,
const ErrorCallback& callback);

Powered by Google App Engine
This is Rietveld 408576698