Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 98503006: Move Skia's variables and defines to skia_common. (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move Skia's variables and defines to skia_common. skia_library_opts was not being compiled with any of these defines. Now it is. Testing: 1) build/gyp_chromium && ninja -C out/Debug 2) Looked for Skia defines in .ninja files master: $ grep -l DSK *.ninja filter_fuzz_stub.ninja image_operations_bench.ninja skia_chrome.ninja skia_library.ninja this CL: $ grep -l DSK *.ninja filter_fuzz_stub.ninja image_operations_bench.ninja skia_chrome.ninja skia_library.ninja skia_opts.ninja skia_opts_none.ninja skia_opts_ssse3.ninja BUG= R=bungeman@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241394

Patch Set 1 #

Patch Set 2 : add warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -146 lines) Patch
M skia/skia_common.gypi View 1 chunk +155 lines, -0 lines 0 comments Download
M skia/skia_library.gypi View 1 8 chunks +5 lines, -146 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
This is a tricky CL to review, I admit. I found putting up both diffs ...
7 years ago (2013-12-13 19:10:26 UTC) #1
bungeman-skia
lgtm
7 years ago (2013-12-13 20:21:31 UTC) #2
mtklein
Ben, I'm out until the 30th. If you're around and this is blocking anything, can ...
7 years ago (2013-12-17 18:09:25 UTC) #3
bungeman-chromium
7 years ago (2013-12-17 22:42:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r241394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698