[turbofan] Add schedule to visualizer output

[turbofan] Add schedule to visualizer output

Committed: https://crrev.com/80e0d42bb2815c33709cf4bddc3f829411bd6ede
Cr-Commit-Position: refs/heads/master@{#27836}

[danno, 2015-03-06 15:11:29]

danno@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[danno, 2015-03-06 15:11:30]

PTAL

[Michael Starzinger, 2015-03-06 17:51:56]

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc
File src/compiler/visualizer.cc (right):

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer....
src/compiler/visualizer.cc:824: std::ostream& operator<<(std::ostream& os, const
ScheduleAsJSON& aj) {
Why is this called ScheduleAsJSON, there doesn't seem to anything JSON specific
in here, this is the same operator that is used to just print to the schedule.

Also why do we need to move it into the visualizer.cc file, I think it belongs
in either schedule.cc as it was before.

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer....
src/compiler/visualizer.cc:849: SourcePosition p =
aj.positions->GetSourcePosition(node);
I assume the visualizer parses these source position annotations. Correct? Would
it be possible to have that as a side-table, outside of the scheduler printout?

https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp#newcode545
tools/gyp/v8.gyp:545: '../../src/compiler/visualizer.cc',
Please also adapt BUILD.gn on the top level.

[danno, 2015-04-09 13:02:35]

Patchset #7 (id:120001) has been deleted

[danno, 2015-04-09 13:02:41]

Patchset #6 (id:100001) has been deleted

[danno, 2015-04-09 13:02:50]

Patchset #5 (id:80001) has been deleted

[danno, 2015-04-09 13:05:23]

Patchset #4 (id:60001) has been deleted

[danno, 2015-04-09 13:50:33]

please take another look

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer.cc
File src/compiler/visualizer.cc (right):

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer....
src/compiler/visualizer.cc:824: std::ostream& operator<<(std::ostream& os, const
ScheduleAsJSON& aj) {
On 2015/03/06 17:51:55, Michael Starzinger wrote:
> Why is this called ScheduleAsJSON, there doesn't seem to anything JSON
specific
> in here, this is the same operator that is used to just print to the schedule.
> 
> Also why do we need to move it into the visualizer.cc file, I think it belongs
> in either schedule.cc as it was before.

Done.

https://codereview.chromium.org/985023002/diff/20001/src/compiler/visualizer....
src/compiler/visualizer.cc:849: SourcePosition p =
aj.positions->GetSourcePosition(node);
On 2015/03/06 17:51:55, Michael Starzinger wrote:
> I assume the visualizer parses these source position annotations. Correct?
Would
> it be possible to have that as a side-table, outside of the scheduler
printout?

Done.

https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/985023002/diff/20001/tools/gyp/v8.gyp#newcode545
tools/gyp/v8.gyp:545: '../../src/compiler/visualizer.cc',
On 2015/03/06 17:51:56, Michael Starzinger wrote:
> Please also adapt BUILD.gn on the top level.

Done.

[Michael Starzinger, 2015-04-10 12:27:10]

LGTM.

[danno, 2015-04-15 09:08:22]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2015-04-15 09:08:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985023002/140001

[commit-bot: I haz the power, 2015-04-15 09:33:32]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-04-15 09:33:42]

Patchset 4 (id:??) landed as
https://crrev.com/80e0d42bb2815c33709cf4bddc3f829411bd6ede
Cr-Commit-Position: refs/heads/master@{#27836}