Correctly allow components to return different top-level nodes during different renderings

sky/framework/fn.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 library fn;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:sky' as sky;
 import 'reflect.dart' as reflect;
@@ skipping 597 matching lines @@
     _currentOrder = _order;
     _currentlyRendering = this;
     _rendered = render();
     _currentlyRendering = null;
     _currentOrder = lastOrder;
 
     _rendered.events.addAll(events);
 
     _dirty = false;
 
-    if (oldRendered != null && _rendered.runtimeType != oldRendered.runtimeType)
+    // TODO(rafaelw): This eagerly removes the old VDOM. It may be that a

[Hixie, 2015/03/06 21:32:52]

Do you mean VDOM here, or DOM? _remove() seems to do both (though I can't quite
tell what it means to remove things from the VDOM, I thought that was an
immutable structure).

[rafaelw, 2015/03/06 21:37:29]

You are correct, it is actually both (concretely, sky DOM nodes must be removed
and any components should get the didUnmount() signal).
Logically yes, though that's not how it's implemented.

+    // new component was rendered that could re-use some of it. Consider
+    // syncing the new VDROM against the old one.

[Hixie, 2015/03/06 21:32:52]

s/VDROM/VDOM/?

[rafaelw, 2015/03/06 21:37:29]

Yeah, I fixed that before landing.

+    if (oldRendered != null && _rendered.runtimeType != oldRendered.runtimeType) {
+      oldRendered._remove();
       oldRendered = null;
+    }
 
     if (_rendered._sync(oldRendered, host, insertBefore)) {
       _rendered = oldRendered; // retain stateful component
     }
     _root = _rendered._root;
     assert(_rendered._root is sky.Node);
 
     if (mounting) {
       didMount();
     }
@@ skipping 36 matching lines @@
 
       _sync(null, _host, null);
       assert(_root is sky.Node);
 
       sw.stop();
       if (_shouldLogRenderDuration)
         print("Initial render: ${sw.elapsedMicroseconds} microseconds");
     });
   }
 }