Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: Source/core/dom/Document.h

Issue 984983002: Do not fire didStartLoading and didStopLoading events twice. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 893 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 BeforeUnloadEventCompleted, 904 BeforeUnloadEventCompleted,
905 PageHideInProgress, 905 PageHideInProgress,
906 UnloadEventInProgress, 906 UnloadEventInProgress,
907 UnloadEventHandled 907 UnloadEventHandled
908 }; 908 };
909 bool loadEventStillNeeded() const { return m_loadEventProgress == LoadEventN otRun; } 909 bool loadEventStillNeeded() const { return m_loadEventProgress == LoadEventN otRun; }
910 bool processingLoadEvent() const { return m_loadEventProgress == LoadEventIn Progress; } 910 bool processingLoadEvent() const { return m_loadEventProgress == LoadEventIn Progress; }
911 bool loadEventFinished() const { return m_loadEventProgress >= LoadEventComp leted; } 911 bool loadEventFinished() const { return m_loadEventProgress >= LoadEventComp leted; }
912 bool unloadStarted() const { return m_loadEventProgress >= PageHideInProgres s; } 912 bool unloadStarted() const { return m_loadEventProgress >= PageHideInProgres s; }
913 bool processingBeforeUnload() const { return m_loadEventProgress == BeforeUn loadEventInProgress; } 913 bool processingBeforeUnload() const { return m_loadEventProgress == BeforeUn loadEventInProgress; }
914 bool shouldFireLoadingEvents() const { return m_loadEventProgress == LoadEve ntCompleted; }
Nate Chapin 2015/03/06 18:22:20 This name seems overly specific to its usage. isNo
Fabrice (no longer in Chrome) 2015/03/06 18:39:13 I kinda like it because it's only really supposed
914 void suppressLoadEvent(); 915 void suppressLoadEvent();
915 916
916 void setContainsPlugins() { m_containsPlugins = true; } 917 void setContainsPlugins() { m_containsPlugins = true; }
917 bool containsPlugins() const { return m_containsPlugins; } 918 bool containsPlugins() const { return m_containsPlugins; }
918 919
919 virtual bool isContextThread() const override final; 920 virtual bool isContextThread() const override final;
920 virtual bool isJSExecutionForbidden() const override final { return false; } 921 virtual bool isJSExecutionForbidden() const override final { return false; }
921 922
922 bool containsValidityStyleRules() const { return m_containsValidityStyleRule s; } 923 bool containsValidityStyleRules() const { return m_containsValidityStyleRule s; }
923 void setContainsValidityStyleRules() { m_containsValidityStyleRules = true; } 924 void setContainsValidityStyleRules() { m_containsValidityStyleRules = true; }
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
1431 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true); 1432 DEFINE_TYPE_CASTS(TreeScope, Document, document, true, true);
1432 1433
1433 } // namespace blink 1434 } // namespace blink
1434 1435
1435 #ifndef NDEBUG 1436 #ifndef NDEBUG
1436 // Outside the WebCore namespace for ease of invocation from gdb. 1437 // Outside the WebCore namespace for ease of invocation from gdb.
1437 void showLiveDocumentInstances(); 1438 void showLiveDocumentInstances();
1438 #endif 1439 #endif
1439 1440
1440 #endif // Document_h 1441 #endif // Document_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698