Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_events.js

Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tmptmptmp
Patch Set: Disable one test one test on mac with bug ref, use document.webkitIsFullScreen Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/guest_view/web_view/web_view_events.js
diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_events.js b/extensions/renderer/resources/guest_view/web_view/web_view_events.js
index bae210e7066ad838070a1e688bd9976f9f0ee47a..22cea250d1defec9416f461039801bc680cf2f5b 100644
--- a/extensions/renderer/resources/guest_view/web_view/web_view_events.js
+++ b/extensions/renderer/resources/guest_view/web_view/web_view_events.js
@@ -55,6 +55,12 @@ WebViewEvents.EVENTS = {
evt: CreateEvent('webViewInternal.onExit'),
fields: ['processId', 'reason']
},
+ 'exitfullscreen': {
+ evt: CreateEvent('webViewInternal.onExitFullscreen'),
+ fields: ['url'],
+ handler: 'handleFullscreenExitEvent',
+ internal: true
+ },
'findupdate': {
evt: CreateEvent('webViewInternal.onFindReply'),
fields: [
@@ -219,6 +225,10 @@ WebViewEvents.prototype.handleFrameNameChangedEvent = function(event) {
this.view.onFrameNameChanged(event.name);
};
+WebViewEvents.prototype.handleFullscreenExitEvent = function(event, eventName) {
+ document.webkitCancelFullScreen();
+};
+
WebViewEvents.prototype.handleLoadAbortEvent = function(event, eventName) {
var showWarningMessage = function(reason) {
var WARNING_MSG_LOAD_ABORTED = '<webview>: ' +
@@ -249,7 +259,12 @@ WebViewEvents.prototype.handleNewWindowEvent = function(event, eventName) {
WebViewEvents.prototype.handlePermissionEvent = function(event, eventName) {
var webViewEvent = this.makeDomEvent(event, eventName);
- new WebViewActionRequests.PermissionRequest(this.view, event, webViewEvent);
+ if (event.permission === 'fullscreen') {
+ new WebViewActionRequests.FullscreenPermissionRequest(
+ this.view, event, webViewEvent);
+ } else {
+ new WebViewActionRequests.PermissionRequest(this.view, event, webViewEvent);
+ }
};
WebViewEvents.prototype.handleSizeChangedEvent = function(event, eventName) {
« no previous file with comments | « extensions/renderer/resources/guest_view/web_view/web_view_action_requests.js ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698