Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 984963003: Fix closure compile. (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compile. TBR=fukino@chromium.org BUG=463853 Committed: https://crrev.com/aee98d8ef5b3c004380ac992d4584cbd08d455e1 Cr-Commit-Position: refs/heads/master@{#319576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/toolbar_controller.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Dan Beam
5 years, 9 months ago (2015-03-07 01:40:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984963003/1
5 years, 9 months ago (2015-03-07 01:42:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 03:44:09 UTC) #5
fukino
lgtm. I'm sorry I didn't noticed this error. Thank you for the fix.
5 years, 9 months ago (2015-03-07 18:34:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984963003/1
5 years, 9 months ago (2015-03-07 18:37:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 20:38:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984963003/1
5 years, 9 months ago (2015-03-08 01:34:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 03:55:54 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 03:56:49 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aee98d8ef5b3c004380ac992d4584cbd08d455e1
Cr-Commit-Position: refs/heads/master@{#319576}

Powered by Google App Engine
This is Rietveld 408576698