Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 984963002: Intrinsics in the INLINE_FUNCTION_LIST are now avaliable without '_', too. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Intrinsics in the INLINE_FUNCTION_LIST are now avaliable without '_', too. This involved renaming apart a few more intrinsics. In the long run, we want to clean up redundant intrinsics which just delegate. BUG=v8:3947 LOG=n Committed: https://crrev.com/d8416f5524830213ce1a618c344d776f50f91bf2 Cr-Commit-Position: refs/heads/master@{#27043}

Patch Set 1 #

Patch Set 2 : Platform ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -48 lines) Patch
M src/arm/code-stubs-arm.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +10 lines, -9 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 5 chunks +21 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/regress/string-compare-memcmp.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
Includes some funky "git cl format" stuff... :-/
5 years, 9 months ago (2015-03-06 13:14:38 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-06 13:38:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984963002/20001
5 years, 9 months ago (2015-03-06 13:41:26 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 13:50:01 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 13:50:15 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8416f5524830213ce1a618c344d776f50f91bf2
Cr-Commit-Position: refs/heads/master@{#27043}

Powered by Google App Engine
This is Rietveld 408576698