Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 984943002: Sync the Window interface with the many specs (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken, Yuki
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the Window interface with the many specs https://html.spec.whatwg.org/#the-window-object and many other specs with partial Window interfaces. Add UseCounters to the non-standard things that didn't already have them, and put MeasureAs/DeprecatedAs at the beginning of each line to make it more obvious that they are all counted. prompt()'s second argument was left as |defaultValue|, as |default| is a C++ keyword. The only changes to the generated code are due to renamed arguments and added UseCounters. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191461

Patch Set 1 #

Total comments: 2

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -36 lines) Patch
M LayoutTests/fast/dom/Window/window-scroll-arguments-expected.txt View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 7 chunks +43 lines, -33 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/988683002/
5 years, 9 months ago (2015-03-06 12:20:57 UTC) #2
haraken
LGTM https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl File Source/core/frame/Window.idl (right): https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl#newcode40 Source/core/frame/Window.idl:40: // FIXME: document should be [Unforgeable]. shiino-san: We ...
5 years, 9 months ago (2015-03-06 12:47:58 UTC) #4
Yuki
https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl File Source/core/frame/Window.idl (right): https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl#newcode40 Source/core/frame/Window.idl:40: // FIXME: document should be [Unforgeable]. On 2015/03/06 12:47:58, ...
5 years, 9 months ago (2015-03-06 13:30:06 UTC) #5
haraken
On 2015/03/06 13:30:06, Yuki wrote: > https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl > File Source/core/frame/Window.idl (right): > > https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl#newcode40 > ...
5 years, 9 months ago (2015-03-06 13:37:37 UTC) #6
haraken
On 2015/03/06 13:37:37, haraken wrote: > On 2015/03/06 13:30:06, Yuki wrote: > > https://codereview.chromium.org/984943002/diff/1/Source/core/frame/Window.idl > ...
5 years, 9 months ago (2015-03-06 13:38:12 UTC) #7
Yuki
On 2015/03/06 13:38:12, haraken wrote: > On 2015/03/06 13:37:37, haraken wrote: > > On 2015/03/06 ...
5 years, 9 months ago (2015-03-06 13:39:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984943002/1
5 years, 9 months ago (2015-03-06 15:57:36 UTC) #10
philipj_slow
On 2015/03/06 13:39:19, Yuki wrote: > On 2015/03/06 13:38:12, haraken wrote: > > On 2015/03/06 ...
5 years, 9 months ago (2015-03-06 15:57:36 UTC) #11
philipj_slow
update test
5 years, 9 months ago (2015-03-06 18:36:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984943002/20001
5 years, 9 months ago (2015-03-06 18:36:20 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 21:13:14 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191461

Powered by Google App Engine
This is Rietveld 408576698