Issue 98493004: Revert 238732 "[SiteChip] Add the basic painting of the site chi..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98493004: Revert 238732 "[SiteChip] Add the basic painting of the site chi..." (Closed)

Created:
7 years ago by michaeln

Modified:
7 years ago

Reviewers:
Greg Billock

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 238732 "[SiteChip] Add the basic painting of the site chi..." > [SiteChip] Add the basic painting of the site chip button. > > R=pkasting@chromium.org > BUG=315944 > > Review URL: https://codereview.chromium.org/75873002 Caused a great many leaks. TBR=gbillock@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238754

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -230 lines)			Patch
D	trunk/src/chrome/browser/ui/views/toolbar/site_chip_view.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	trunk/src/chrome/browser/ui/views/toolbar/site_chip_view.cc	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/toolbar/toolbar_view.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/toolbar/toolbar_view.cc	View	7 chunks	+1 line, -36 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_ui.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r238754.