Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 984893003: CpuProfiler: fix for CollectDeoptEvents test on arm64 (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: support dept tracking for frameless and save_doubles entries Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/arm64/lithium-codegen-arm64.cc ('K') | « src/deoptimizer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index a990f987cdd8459a9685aa73f32c4264f32cb3a8..5b17b135daac7536e1bc98734222a72d4dc25451 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1771,8 +1771,12 @@ TEST(CollectDeoptEvents) {
}
{
const char* branch[] = {"", "opt_function1", "opt_function1"};
- CHECK_EQ(reason(i::Deoptimizer::kNaN),
- GetBranchDeoptReason(iprofile, branch, arraysize(branch)));
+ const char* deopt_reason =
+ GetBranchDeoptReason(iprofile, branch, arraysize(branch));
+ if (deopt_reason != reason(i::Deoptimizer::kNaN) &&
+ deopt_reason != reason(i::Deoptimizer::kLostPrecisionOrNaN)) {
+ FATAL(deopt_reason);
+ }
}
{
const char* branch[] = {"", "opt_function2", "opt_function2"};
« src/arm64/lithium-codegen-arm64.cc ('K') | « src/deoptimizer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698