Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: ash/system/chromeos/network/vpn_delegate.cc

Issue 984863005: Add ash::VPNDelegate and Chrome OS implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a VPNProvider::Key abstraction. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/network/vpn_delegate.cc
diff --git a/ash/system/chromeos/network/vpn_delegate.cc b/ash/system/chromeos/network/vpn_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..22e7768e1374be9c672987092bc002dd137ffdc6
--- /dev/null
+++ b/ash/system/chromeos/network/vpn_delegate.cc
@@ -0,0 +1,57 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/system/chromeos/network/vpn_delegate.h"
+
+#include "chromeos/network/network_state.h"
+#include "third_party/cros_system_api/dbus/service_constants.h"
+
+namespace ash {
+
+VPNProvider::Key::Key() : third_party(false) {
+}
+
+VPNProvider::Key::Key(const std::string& extension_id)
+ : third_party(true), extension_id(extension_id) {
+}
+
+bool VPNProvider::Key::operator==(const Key& other) const {
+ return other.third_party == third_party && other.extension_id == extension_id;
+}
+
+bool VPNProvider::Key::MatchesNetwork(
+ const chromeos::NetworkState& network) const {
+ if (network.type() != shill::kTypeVPN)
+ return false;
+ if (third_party)
+ return network.vpn_provider_extension_id() == extension_id;
+ return network.vpn_provider_extension_id().empty();
stevenjb 2015/03/12 17:40:45 We should comment this. It seems at some point we
bartfab (slow) 2015/03/17 12:38:21 Done.
+}
+
+VPNProvider::VPNProvider(const Key& key, const std::string& name)
+ : key(key), name(name) {
+}
+
+VPNDelegate::Observer::~Observer() {
+}
+
+VPNDelegate::VPNDelegate() {
+}
+
+VPNDelegate::~VPNDelegate() {
+}
+
+void VPNDelegate::AddObserver(Observer* observer) {
+ observer_list_.AddObserver(observer);
+}
+
+void VPNDelegate::RemoveObserver(Observer* observer) {
+ observer_list_.RemoveObserver(observer);
+}
+
+void VPNDelegate::NotifyObservers() {
+ FOR_EACH_OBSERVER(Observer, observer_list_, OnVPNProvidersChanged());
+}
+
+} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698