Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1542)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 984853003: Service Worker: Clients.openWindow() should allow opening x-origin URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 14661847051a74b91dcb8f6c4c6e3ae4b4e6ccb1..ecc0c9585aee0e313b2d8d96365f5ef7e1f17d18 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -468,6 +468,7 @@ void ServiceWorkerScriptContext::OnDidGetClientDocuments(
void ServiceWorkerScriptContext::OnOpenWindowResponse(
int request_id,
+ const GURL& url,
const ServiceWorkerClientInfo& client) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerScriptContext::OnOpenWindowResponse");
@@ -483,7 +484,10 @@ void ServiceWorkerScriptContext::OnOpenWindowResponse(
web_client.reset(new blink::WebServiceWorkerClientInfo(
ToWebServiceWorkerClientInfo(client)));
}
- callbacks->onSuccess(web_client.release());
+ if (url.GetOrigin() != client.url.GetOrigin())
+ callbacks->onSuccess(nullptr);
+ else
+ callbacks->onSuccess(web_client.release());
pending_client_callbacks_.Remove(request_id);
}

Powered by Google App Engine
This is Rietveld 408576698