Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 984833003: Do not use eternal handles when creating a start-up snapshot. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not use eternal handles when creating a start-up snapshot. R=ulan@chromium.org Committed: https://crrev.com/5de20c05d54f0d0585b083764bdd8d78cb7ef350 Cr-Commit-Position: refs/heads/master@{#27045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/date.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 9 months ago (2015-03-06 13:39:36 UTC) #1
ulan
lgtm
5 years, 9 months ago (2015-03-06 13:43:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984833003/1
5 years, 9 months ago (2015-03-06 14:10:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 14:44:46 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 14:45:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5de20c05d54f0d0585b083764bdd8d78cb7ef350
Cr-Commit-Position: refs/heads/master@{#27045}

Powered by Google App Engine
This is Rietveld 408576698