Fix CustomLauncherPageBrowserTest.LauncherPageFocusTraversal flake.

Fix CustomLauncherPageBrowserTest.LauncherPageFocusTraversal flake.

This CL fixes the test by using FocusManager::GetNextFocusableView
instead of actually setting focus, which was causing flake because other
concurrent browser tests could change the focused view.

BUG=463456
Committed: https://crrev.com/d7763b1132b761c2c0128529721a6d1f899796bb
Cr-Commit-Position: refs/heads/master@{#321949}

[calamity, 2015-03-10 03:19:59]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org

[benwells, 2015-03-11 19:53:41]

https://codereview.chromium.org/984813002/diff/1/chrome/browser/apps/custom_l...
File chrome/browser/apps/custom_launcher_page_browsertest_views.cc (right):

https://codereview.chromium.org/984813002/diff/1/chrome/browser/apps/custom_l...
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:414: views::View*
webview_textfield =
This tests that the search box text field, and some other view, are the only
focusable views. Is there some way to confirm the other view is the webview?

[calamity, 2015-03-24 00:40:19]

Patchset #2 (id:20001) has been deleted

[calamity, 2015-03-24 00:42:49]

https://codereview.chromium.org/984813002/diff/1/chrome/browser/apps/custom_l...
File chrome/browser/apps/custom_launcher_page_browsertest_views.cc (right):

https://codereview.chromium.org/984813002/diff/1/chrome/browser/apps/custom_l...
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:414: views::View*
webview_textfield =
On 2015/03/11 19:53:41, benwells wrote:
> This tests that the search box text field, and some other view, are the only
> focusable views. Is there some way to confirm the other view is the webview?

Ah yeah, I thought I wouldn't be able to do it, but it turns out my initial
assumption was wrong. The webview is in fact the focused view which passes focus
to the renderwidget which does the textfield focus internally. So... Yeah. Done.

[calamity, 2015-03-24 00:46:33]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-03-24 00:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984813002/40001

[commit-bot: I haz the power, 2015-03-24 00:47:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-24 00:47:20]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[benwells, 2015-03-24 03:36:59]

lgtm

[calamity, 2015-03-24 07:07:09]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2015-03-24 07:07:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984813002/40001

[commit-bot: I haz the power, 2015-03-24 07:46:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-24 07:46:51]

Patchset 2 (id:??) landed as
https://crrev.com/d7763b1132b761c2c0128529721a6d1f899796bb
Cr-Commit-Position: refs/heads/master@{#321949}