content: Add histogram for discardable memory allocation size.

content/child/child_discardable_shared_memory_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/child_discardable_shared_memory_manager.h"
 
 #include "base/debug/crash_logging.h"
 #include "base/memory/discardable_shared_memory.h"
+#include "base/metrics/histogram.h"
 #include "base/process/process_metrics.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/trace_event/trace_event.h"
 #include "content/common/child_process_messages.h"
 
 namespace content {
 namespace {
 
 // Default allocation size.
 #if defined(OS_ANDROID)
@@ skipping 40 matching lines @@
     BytesAllocatedChanged(0);
 }
 
 scoped_ptr<base::DiscardableMemoryShmemChunk>
 ChildDiscardableSharedMemoryManager::AllocateLockedDiscardableMemory(
     size_t size) {
   base::AutoLock lock(lock_);
 
   DCHECK_NE(size, 0u);
 
+  UMA_HISTOGRAM_CUSTOM_COUNTS("Memory.DiscardableAllocationSize",
+                              size / 1024,  // In KB
+                              0,

[Alexei Svitkine (slow), 2015/03/06 15:49:08]

There is already a default overflow bucket between 0 and the min value you
specify here. So this should be 1.

[reveman, 2015/03/07 23:05:45]

Done.

+                              4 * 1024 * 1024,  // 4 GB
+                              256);

[Alexei Svitkine (slow), 2015/03/06 15:49:08]

Why do you need 256 buckets? This is much more than other histograms and I'm
skeptical you actual need this many, but happy to discuss the details.

[reveman, 2015/03/07 23:05:45]

Reduced it to 50 which is the same as UMA_HISTOGRAM_MEMORY_KB. I'm not sure
that's enough but we can start with that. The majority of samples will be in the
1-1000KB range with some samples anywhere from 1MB to multiple GBs. I'm
interested in both the distribution of samples in the 0-1MB range as well as the
more rare large allocations. Maybe I can use a logarithmic scale..

[reveman, 2015/03/09 00:31:21]

Just realized that the bucket layout is already exponential by default so 50
buckets as in the latest patch should be more than enough. Sorry for the noise..

+
   // Round up to multiple of page size.
   size_t pages = (size + base::GetPageSize() - 1) / base::GetPageSize();
 
   for (;;) {
     // Search free list for available space.
     scoped_ptr<DiscardableSharedMemoryHeap::Span> free_span =
         heap_.SearchFreeList(pages);
     if (!free_span.get())
       break;
 
@@ skipping 148 matching lines @@
     size_t new_bytes_allocated) const {
   TRACE_COUNTER_ID1("renderer", "DiscardableMemoryUsage", this,
                     new_bytes_allocated);
 
   static const char kDiscardableMemoryUsageKey[] = "dm-usage";
   base::debug::SetCrashKeyValue(kDiscardableMemoryUsageKey,
                                 base::Uint64ToString(new_bytes_allocated));
 }
 
 }  // namespace content