[Webapp Refactor] Remove It2Me connection code from SessionConnectorImpl.

remoting/webapp/crd/js/crd_connect.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Functions related to the 'client screen' for Chromoting.
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * Initiate an IT2Me connection.
  */
 remoting.connectIT2Me = function() {
   var connector = remoting.app.getSessionConnector();
   var accessCode = document.getElementById('access-code-entry').value;
   remoting.setMode(remoting.AppMode.CLIENT_CONNECTING);
-  connector.connectIT2Me(accessCode);
+  remoting.It2MeConnectFlow.start(connector, accessCode).catch(
+    function(reason){

[garykac, 2015/03/06 22:27:27]

formatting nit: What do you think about starting this line with 'catch' to make
it more obvious that this is error-handling code?

remoting.It2MeConnectFlow.start(connector, accessCode).
    catch(function(reason){
      var errorDiv = document.getElementById('connect-error-message');
      l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (reason));
      remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
    });

(frankly, I would prefer the line to start with '.catch', but Chrome style wants
'.'s at the end of the line :-( )

[kelvinp, 2015/03/06 23:33:51]

Done.

+      var errorDiv = document.getElementById('connect-error-message');
+      l10n.localizeElementFromTag(errorDiv, /** @type {string} */ (reason));
+      remoting.setMode(remoting.AppMode.CLIENT_CONNECT_FAILED_IT2ME);
+  });
 };
 
 /**
  * Entry-point for Me2Me connections, handling showing of the host-upgrade nag
  * dialog if necessary.
  *
  * @param {string} hostId The unique id of the host.
  * @return {void} Nothing.
  */
 remoting.connectMe2Me = function(hostId) {
@@ skipping 121 matching lines @@
     if (pairingInfo) {
       clientId = /** @type {string} */ (pairingInfo['clientId']);
       sharedSecret = /** @type {string} */ (pairingInfo['sharedSecret']);
     }
     connector.connectMe2Me(host, requestPin, fetchThirdPartyToken,
                                     clientId, sharedSecret);
   }
 
   remoting.HostSettings.load(host.hostId, connectMe2MeHostSettingsRetrieved);
 };