Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: sky/examples/fn/widgets/floating_action_button.dart

Issue 984793002: The floating action button should have a shadow (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/fn/widgets/floating_action_button.dart
diff --git a/sky/examples/fn/widgets/floating_action_button.dart b/sky/examples/fn/widgets/floating_action_button.dart
index e0853aab029522a8d4f8c87f056e109dd1f317d9..ca70e5dc0d4636daed9677ee39f46c597835dd35 100644
--- a/sky/examples/fn/widgets/floating_action_button.dart
+++ b/sky/examples/fn/widgets/floating_action_button.dart
@@ -1,9 +1,6 @@
part of widgets;
class FloatingActionButton extends MaterialComponent {
- // TODO(rafaelw): Ganesh has problems with box shadows
- // box-shadow: 0 10px 20px rgba(0,0,0,0.19), 0 6px 6px rgba(0,0,0,0.23);
-
static final Style _style = new Style('''
position: absolute;
bottom: 16px;
@@ -14,6 +11,7 @@ class FloatingActionButton extends MaterialComponent {
height: 56px;
background-color: ${Red[500]};
color: white;
+ box-shadow: ${Shadow[3]};
border-radius: 28px;'''
);
static final Style _clipStyle = new Style('''
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698