Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 984793002: The floating action button should have a shadow (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

The floating action button should have a shadow This provokes a rendering bug in MojoShell but not in SkyShell. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/46cd025bccfa603402abb17bd5158c9b34949cd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M sky/examples/fn/widgets/floating_action_button.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-06 00:57:02 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-06 01:01:21 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-06 01:56:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46cd025bccfa603402abb17bd5158c9b34949cd8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698