Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 984773003: CpuProfiler: fix for GetDeoptReason code. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: fix for GetDeoptReason code. The original code always returned the first entry from RelocInfo that matched with bailout_id. But we may have a few different deopt reasons for one bailout_id. So we need to get the one which matches with a particular call from JumpTable. We can do this by checking not 'target_address' (it maps to bailout_id) but 'from' address which maps to a particular JumpTable entry. The test was reworked so it tests identical functions against different reasons. BUG=chromium:452067 LOG=n Committed: https://crrev.com/66ab309e73ad8156160bc753c46494506ef8fdaa Cr-Commit-Position: refs/heads/master@{#27076}

Patch Set 1 #

Patch Set 2 : win platform was fixed #

Total comments: 2

Patch Set 3 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -60 lines) Patch
M src/cpu-profiler.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/cpu-profiler.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.cc View 1 2 3 chunks +5 lines, -20 lines 0 comments Download
M src/log.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/log.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 3 chunks +54 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-06 16:47:00 UTC) #2
loislo
PTAL
5 years, 9 months ago (2015-03-07 07:25:17 UTC) #4
Sven Panne
https://codereview.chromium.org/984773003/diff/20001/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/984773003/diff/20001/src/cpu-profiler.cc#newcode332 src/cpu-profiler.cc:332: void CpuProfiler::CodeDeoptEvent(Code* code, int bailout_id, Address pc, Can we ...
5 years, 9 months ago (2015-03-09 11:38:53 UTC) #5
loislo
https://codereview.chromium.org/984773003/diff/20001/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/984773003/diff/20001/src/cpu-profiler.cc#newcode332 src/cpu-profiler.cc:332: void CpuProfiler::CodeDeoptEvent(Code* code, int bailout_id, Address pc, On 2015/03/09 ...
5 years, 9 months ago (2015-03-09 14:12:34 UTC) #6
Sven Panne
lgtm
5 years, 9 months ago (2015-03-09 14:41:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984773003/40001
5 years, 9 months ago (2015-03-09 14:42:19 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 14:43:34 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 14:43:52 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/66ab309e73ad8156160bc753c46494506ef8fdaa
Cr-Commit-Position: refs/heads/master@{#27076}

Powered by Google App Engine
This is Rietveld 408576698