Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 98473004: Syncfs-internal: Return empty value if metadata_database is not yet initialized (Closed)

Created:
7 years ago by kinuko
Modified:
7 years ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Visibility:
Public.

Description

Syncfs-internal: Return empty value if metadata_database is not yet initialized Otherwise it could crash the browser process BUG=325046 TEST=manual (launch Chrome, immediately open syncfs-internals) R=nhiroki@chromium.org, tzik@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
PTL
7 years ago (2013-12-03 05:50:37 UTC) #1
tzik
lgtm
7 years ago (2013-12-03 05:51:56 UTC) #2
nhiroki
LGTM Can you add "325046" to BUG=?
7 years ago (2013-12-03 05:54:39 UTC) #3
kinuko
On 2013/12/03 05:54:39, nhiroki wrote: > LGTM > > Can you add "325046" to BUG=? ...
7 years ago (2013-12-03 05:55:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/98473004/1
7 years ago (2013-12-03 05:57:27 UTC) #5
kinuko
7 years ago (2013-12-03 10:39:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r238340 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698