Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 984723003: Implement ServiceWorkerRegistration related DevTools events [1/2 blink] (Closed)

Created:
5 years, 9 months ago by horo
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement ServiceWorkerRegistration related DevTools events [1/2 blink] This cl introduces the floowing events. - workerRegistrationUpdated - workerVersionUpdated - workerRegistrationDeleted 1/2 blink: https://codereview.chromium.org/984723003/ 1/2 chromium: https://codereview.chromium.org/985663002/ BUG=463892 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191596

Patch Set 1 #

Total comments: 2

Patch Set 2 : change to push model #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 1 chunk +27 lines, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 2 chunks +47 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pfeldman
https://codereview.chromium.org/984723003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/984723003/diff/1/Source/devtools/protocol.json#newcode4116 Source/devtools/protocol.json:4116: { "name": "origin", "type": "string", "description": "Security origin of ...
5 years, 9 months ago (2015-03-06 10:43:16 UTC) #2
horo
https://codereview.chromium.org/984723003/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/984723003/diff/1/Source/devtools/protocol.json#newcode4116 Source/devtools/protocol.json:4116: { "name": "origin", "type": "string", "description": "Security origin of ...
5 years, 9 months ago (2015-03-09 12:33:25 UTC) #3
pfeldman
lgtm
5 years, 9 months ago (2015-03-09 19:05:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984723003/20001
5 years, 9 months ago (2015-03-10 00:22:56 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 01:54:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191596

Powered by Google App Engine
This is Rietveld 408576698