Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 98463013: add virtual destructor for SkExample to fix build error (Closed)

Created:
7 years ago by yunchao
Modified:
7 years ago
Reviewers:
caryclark
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add virtual destructor for SkExample to fix build error. The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples": error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor. Committed: http://code.google.com/p/skia/source/detail?r=12728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M experimental/SkiaExamples/SkExample.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yunchao
7 years ago (2013-12-17 03:25:41 UTC) #1
caryclark
lgtm
7 years ago (2013-12-17 15:06:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/98463013/1
7 years ago (2013-12-17 23:29:14 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-17 23:37:43 UTC) #4
Message was sent while issue was closed.
Change committed as 12728

Powered by Google App Engine
This is Rietveld 408576698