chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h - Issue 98463012: Infinite Suggest for mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.h

Issue 98463012: Infinite Suggest for mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewer comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm ('K') | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm ('k') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm » ('j') | chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_

6 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_	6 #define CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 91 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
102 void OpenURLForRow(size_t row, WindowOpenDisposition disposition);	102 void OpenURLForRow(size_t row, WindowOpenDisposition disposition);

103	103

104 OmniboxView* omnibox_view_;	104 OmniboxView* omnibox_view_;

105 scoped_ptr<OmniboxPopupModel> model_;	105 scoped_ptr<OmniboxPopupModel> model_;

106 NSTextField* field_; // owned by tab controller	106 NSTextField* field_; // owned by tab controller

107	107

108 // Child window containing a matrix which implements the popup.	108 // Child window containing a matrix which implements the popup.

109 base::scoped_nsobject<NSWindow> popup_;	109 base::scoped_nsobject<NSWindow> popup_;

110 NSRect target_popup_frame_;	110 NSRect target_popup_frame_;

111	111

	112 CGFloat content_offsetx_;
	Scott Hess - ex-Googler 2013/12/14 00:40:57 Is this ever used? Doesn't seem necessary. Is this ever used? Doesn't seem necessary. Anuj 2013/12/16 02:53:19 Done. Show quoted text On 2013/12/14 00:40:57, shess wrote: > Is this ever used? Doesn't seem necessary. Done.
	113

112 base::scoped_nsobject<OmniboxPopupMatrix> matrix_;	114 base::scoped_nsobject<OmniboxPopupMatrix> matrix_;

113 base::scoped_nsobject<NSView> top_separator_view_;	115 base::scoped_nsobject<NSView> top_separator_view_;

114 base::scoped_nsobject<NSView> bottom_separator_view_;	116 base::scoped_nsobject<NSView> bottom_separator_view_;

115 base::scoped_nsobject<NSBox> background_view_;	117 base::scoped_nsobject<NSBox> background_view_;

116	118

117 DISALLOW_COPY_AND_ASSIGN(OmniboxPopupViewMac);	119 DISALLOW_COPY_AND_ASSIGN(OmniboxPopupViewMac);

118 };	120 };

119	121

120 #endif // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_	122 #endif // CHROME_BROWSER_UI_COCOA_OMNIBOX_OMNIBOX_POPUP_VIEW_MAC_H_

OLD	NEW