Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 984593002: Use Object.observe() instead of Polyfills (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Object.observe() instead of Polyfills This is a clean up CL and should not change any behavior. BUG=none TEST=browsertest passes Committed: https://crrev.com/5d73807f1fea63c692efe744b60365c29884ea0a Cr-Commit-Position: refs/heads/master@{#319602}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Modified comments. #

Total comments: 1

Patch Set 4 : Fix the wrong comment. #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -67 lines) Patch
M ui/file_manager/audio_player/elements/audio_player.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ui/file_manager/audio_player/elements/track_list.js View 1 2 3 3 chunks +19 lines, -8 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player.js View 1 2 4 chunks +54 lines, -47 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_model.js View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/file_manager/audio_player/js/audio_player_scripts.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-03-06 08:45:54 UTC) #2
fukino
lgtm with a nit. https://codereview.chromium.org/984593002/diff/40001/ui/file_manager/audio_player/elements/track_list.js File ui/file_manager/audio_player/elements/track_list.js (right): https://codereview.chromium.org/984593002/diff/40001/ui/file_manager/audio_player/elements/track_list.js#newcode136 ui/file_manager/audio_player/elements/track_list.js:136: * @param {Array.<Object>} splices The ...
5 years, 9 months ago (2015-03-06 12:14:21 UTC) #3
fukino
lgtm with a nit.
5 years, 9 months ago (2015-03-06 12:14:23 UTC) #4
yoshiki
Thank you for reviewing!
5 years, 9 months ago (2015-03-09 07:47:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984593002/60001
5 years, 9 months ago (2015-03-09 07:47:56 UTC) #8
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 08:10:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984593002/80001
5 years, 9 months ago (2015-03-09 08:41:06 UTC) #14
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:10:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984593002/80001
5 years, 9 months ago (2015-03-09 09:35:16 UTC) #21
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 09:35:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984593002/80001
5 years, 9 months ago (2015-03-09 12:05:03 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-09 12:05:51 UTC) #27
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 12:06:47 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5d73807f1fea63c692efe744b60365c29884ea0a
Cr-Commit-Position: refs/heads/master@{#319602}

Powered by Google App Engine
This is Rietveld 408576698