[Blink] Adding Writing direction to the context menu for Aura.

[Blink] Adding Writing direction to the context menu for Aura.

Chromium side CL is here : https://codereview.chromium.org/83163002/

BUG=91178
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163321

[pals, 2013-12-05 13:59:39]

Removed the #ifs as the "Writing direction" in context menu will appear on all
platform now. Please review.

[eseidel, 2013-12-05 16:27:47]

Lgtm
On Dec 5, 2013 5:59 AM, <sanjoy.pal@samsung.com> wrote:

> Reviewers: eseidel,
>
> Message:
> Removed the #ifs as the "Writing direction" in context menu will appear on
> all
> platform now. Please review.
>
> Description:
> [Blink] Adding Writing direction to the context menu for Aura.
>
> Chromium side CL is here : https://codereview.chromium.org/83163002/
>
> BUG=91178
>
> Please review this at https://codereview.chromium.org/98453005/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+0, -3 lines):
>   M Source/web/ContextMenuClientImpl.cpp
>   M public/web/WebContextMenuData.h
>
>
> Index: Source/web/ContextMenuClientImpl.cpp
> diff --git a/Source/web/ContextMenuClientImpl.cpp b/Source/web/
> ContextMenuClientImpl.cpp
> index e826937243dda2333f04a4b410680e2b74c63c2f..
> 9f73af9017316e09f209d78a86c23d8b30647066 100644
> --- a/Source/web/ContextMenuClientImpl.cpp
> +++ b/Source/web/ContextMenuClientImpl.cpp
> @@ -348,12 +348,10 @@ void ContextMenuClientImpl::showContextMenu(const
> WebCore::ContextMenu* defaultM
>          }
>      }
>
> -#if OS(MACOSX) || OS(LINUX)
>      if (selectedFrame->editor().selectionHasStyle(CSSPropertyDirection,
> "ltr") != FalseTriState)
>          data.writingDirectionLeftToRight |= WebContextMenuData::
> CheckableMenuItemChecked;
>      if (selectedFrame->editor().selectionHasStyle(CSSPropertyDirection,
> "rtl") != FalseTriState)
>          data.writingDirectionRightToLeft |= WebContextMenuData::
> CheckableMenuItemChecked;
> -#endif // OS(MACOSX) || OS(LINUX)
>
>      // Now retrieve the security info.
>      DocumentLoader* dl = selectedFrame->loader().documentLoader();
> Index: public/web/WebContextMenuData.h
> diff --git a/public/web/WebContextMenuData.h b/public/web/
> WebContextMenuData.h
> index 5090c11e19d7cb1f8164da3e7a4e7c08fad006fb..
> 8c8459d2f5920619101ec93c86d6567d1d18d8d6 100644
> --- a/public/web/WebContextMenuData.h
> +++ b/public/web/WebContextMenuData.h
> @@ -137,7 +137,6 @@ struct WebContextMenuData {
>
>      // Writing direction menu items - values are unions of
>      // CheckableMenuItemFlags.
> -    // Currently only used on OS X and Linux.
>      int writingDirectionDefault;
>      int writingDirectionLeftToRight;
>      int writingDirectionRightToLeft;
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-06 02:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/98453005/1

[commit-bot: I haz the power, 2013-12-06 12:53:39]

Change committed as 163321