Enable toolkit_views=1 by default on Mac

Enable toolkit_views=1 by default on Mac

As announced on chromium-dev: http://goo.gl/NqrmLk (and after
discussions with chrome-eng-review).

This CL shouldn't change any user-visible UI, just change the way Chrome
is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
rather than the (outdated) ui/app_list/cocoa/.

A ~0.43% sizes regression on Mac is expected with this CL (~652kB
uncompressed). Full details in a doc: http://goo.gl/oHucmf

With this change, toolkit-views test cases in interactive_ui_tests will
start running on bots. views_unittests will be added to the Mac bots in
a follow-up.

BUG=363529
Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
Cr-Commit-Position: refs/heads/master@{#321075}

Committed: https://crrev.com/1ebbc90cc5e90df29fbfc0c72d792c71f09351c1
Cr-Commit-Position: refs/heads/master@{#321294}

[tapted, 2015-03-12 00:56:23]

Patchset #3 (id:40001) has been deleted

[tapted, 2015-03-12 00:56:38]

Patchset #2 (id:20001) has been deleted

[tapted, 2015-03-13 05:57:37]

Patchset #2 (id:60001) has been deleted

[tapted, 2015-03-17 22:26:53]

Patchset #6 (id:150011) has been deleted

[tapted, 2015-03-17 22:27:06]

Patchset #5 (id:140001) has been deleted

[tapted, 2015-03-17 22:27:28]

Patchset #4 (id:120001) has been deleted

[tapted, 2015-03-17 22:27:36]

Patchset #3 (id:100001) has been deleted

[tapted, 2015-03-17 22:43:08]

Patchset #4 (id:190001) has been deleted

[tapted, 2015-03-17 23:04:56]

tapted@chromium.org changed reviewers:
+ scottmg@chromium.org, sky@chromium.org

[tapted, 2015-03-17 23:04:57]

Hi sky and scottmg (for src/build owners), I think this is ready to go - please
take a look.

Plan from here is to wait until PST evening, double-check the try-runs (patchset
3 has a green run) monitor the waterfall and
https://codereview.chromium.org/search?closed=3&commit=2&order=&limit=300 to
ensure things are stable/caught-up, then coordinate on #chromium to land this
change through the CQ.

Hopefully it sticks, but I'll revert if things go awry.

Then: land the sizes rebaseline (and file a bug to track cc:perf-folks to
track), and keep monitoring mac bots for stability.

Finally, update the chromium-dev thread, pass the baton to andre and go to
sleep.

[sky, 2015-03-17 23:11:50]

Awesome! Here's to hoping it sticks.

[scottmg, 2015-03-17 23:18:39]

lgtm. Can you add the size-in-bytes next to % growth? (% can be a bit misleading
these days since chrome is kind of enormous)

[tapted, 2015-03-17 23:20:07]

Thanks!

On 2015/03/17 23:18:39, scottmg wrote:
> lgtm. Can you add the size-in-bytes next to % growth? (% can be a bit
misleading
> these days since chrome is kind of enormous)

Done.

[tapted, 2015-03-18 04:34:23]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2015-03-18 04:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984513002/210001

[commit-bot: I haz the power, 2015-03-18 04:38:17]

Committed patchset #4 (id:210001)

[commit-bot: I haz the power, 2015-03-18 04:39:09]

Patchset 4 (id:??) landed as
https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
Cr-Commit-Position: refs/heads/master@{#321075}

[tapted, 2015-03-18 05:16:43]

A revert of this CL (patchset #4 id:210001) has been created in
https://codereview.chromium.org/1011363002/ by tapted@chromium.org.

The reason for reverting is: Failing on GN build :(.

Link: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/5288

E.g. display_change_listener_aura.cc:38:43:error: member access into incomplete
type 'NSView'.

[tapted, 2015-03-18 10:17:23]

GN Fix is in https://codereview.chromium.org/1011323003/

Nothing else showed up in the waterfall runs (just a known flake --
http://crbug.com/466671 ). So this should be safe to land after that.

[jackhou1, 2015-03-19 03:12:14]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2015-03-19 03:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984513002/210001

[commit-bot: I haz the power, 2015-03-19 04:44:15]

Committed patchset #4 (id:210001)

[commit-bot: I haz the power, 2015-03-19 04:44:50]

Patchset 4 (id:??) landed as
https://crrev.com/1ebbc90cc5e90df29fbfc0c72d792c71f09351c1
Cr-Commit-Position: refs/heads/master@{#321294}

[tapted, 2015-03-19 12:19:26]

Waterfall looks content with this, but an unlikely catastrophe in Canary could
still warrant a revert.

I've updated chromium-dev.

Sizes bug is http://crbug.com/468637 to track, but it's as-expected, so will
probably be closed after checking with perf-sheriffs.