Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 984463003: Revert of Revert of Revert of Turn on job based recompilation (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/955723002/) Reason for revert: Breaks Octane on Arm64 running on Chrome. BUG=464538 Original issue's description: > Revert of Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/937263004/) > > Reason for revert: > reland > > Original issue's description: > > Revert of Turn on job based recompilation (patchset #1 id:1 of https://codereview.chromium.org/935243003/) > > > > Reason for revert: > > waterfall disagrees > > > > Original issue's description: > > > Turn on job based recompilation > > > > > > BUG=v8:3608 > > > R=yangguo@chromium.org > > > LOG=y > > > > > > Committed: https://crrev.com/4ae82f64b09cdc0182cee3a5cc619a9117ac5fbc > > > Cr-Commit-Position: refs/heads/master@{#26826} > > > > TBR=yangguo@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:3608 > > > > Committed: https://crrev.com/35cc692aecdea54fb07479b8d7b71059851e07e8 > > Cr-Commit-Position: refs/heads/master@{#26827} > > TBR=yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3608 > > Committed: https://crrev.com/3735a0851a9e2726f8b50a46a3bc770992328264 > Cr-Commit-Position: refs/heads/master@{#26829} TBR=yangguo@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3608 Committed: https://crrev.com/087c8298a0a37561702e502f07af03c9a6949d23 Cr-Commit-Position: refs/heads/master@{#27052}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
Created Revert of Revert of Revert of Turn on job based recompilation
5 years, 9 months ago (2015-03-06 18:23:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984463003/1
5 years, 9 months ago (2015-03-06 18:24:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 18:24:34 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 18:24:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/087c8298a0a37561702e502f07af03c9a6949d23
Cr-Commit-Position: refs/heads/master@{#27052}

Powered by Google App Engine
This is Rietveld 408576698