Issue 98443003: Apply DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION to HTMLUnknownElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98443003: Apply DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION to HTMLUnknownElement (Closed)

Created:
7 years ago by gyuyoung-inactive

Modified:
7 years ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Apply DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION to HTMLUnknownElement DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION supports more plenty helper functions than manual toFoo(). BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162965

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	Source/core/html/HTMLUnknownElement.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 7 (0 generated)

tkent

> inline bool isHTMLUnknownElement(const Node* node) This function use not used. It should be removed.

7 years ago (2013-12-02 06:54:21 UTC) #2

tkent

On 2013/12/02 06:54:21, tkent wrote: > > inline bool isHTMLUnknownElement(const Node* node) > > This ...

7 years ago (2013-12-02 06:54:41 UTC) #3

gyuyoung-inactive

On 2013/12/02 06:54:21, tkent wrote: > > inline bool isHTMLUnknownElement(const Node* node) > > This ...

7 years ago (2013-12-02 07:11:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/98443003/20001

7 years ago (2013-12-02 07:15:33 UTC) #6

Message was sent while issue was closed.

Change committed as 162965