Issue 984393002: gtest, gmock: disable incompatible warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 984393002: gtest, gmock: disable incompatible warnings (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

gtest, gmock: disable incompatible warnings. gtest and gmock both rely heavily on exit-time destructors, and must build with -Wno-exit-time-destructors to avoid these warnings. gmock’s MOCK_METHODn() macros violate -Wno-inconsistent-missing-override, so this warning is disabled for direct dependents of gmock. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/db7a933d95fd3f29c84ab21d299ac1b6873de577

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -0 lines)			Patch
	M	third_party/gmock/gmock.gyp	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
	M	third_party/gtest/gtest.gyp	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Mark Mentovai

5 years, 9 months ago (2015-03-09 01:04:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
db7a933d95fd3f29c84ab21d299ac1b6873de577 (presubmit successful).