Fixed crash in CloudPolicyManager.

Fixed crash in CloudPolicyManager.

The ComponentCloudPolicyService is created whenever a user signs in, but isn't
cleared when the user signs out; signing out and back in leads to this crash:

[2774:2774:1126/144024:FATAL:cloud_policy_manager.cc(111)] Check failed: !component_policy_service_.
[0x7f9aa98bba3c] policy::CloudPolicyManager::CreateComponentCloudPolicyService()
[0x7f9aa9518eaf] policy::UserCloudPolicyManager::Connect()
[0x7f9aa951a321] policy::UserPolicySigninService::InitializeUserCloudPolicyManager()
[0x7f9aa951a2af] policy::UserPolicySigninService::OnRefreshTokenAvailable()
[0x7f9aaab639d9] OAuth2TokenService::FireRefreshTokenAvailable()
[0x7f9aa91dbfc9] ProfileOAuth2TokenService::UpdateCredentials()
[0x7f9aa8c9647b] SigninManager::CompletePendingSignin()
[0x7f9aaa2d4b5f] OneClickSigninSyncStarter::ConfirmAndSignin()

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238381

[Joao da Silva, 2013-12-02 10:47:05]

@Bartosz: PTAL

@Dominic: FYI. Thanks for reporting :-)

[bartfab (slow), 2013-12-02 18:08:46]

lgtm

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:88:
DCHECK(!value.empty());
Nit 1: #include "base/logging.h"
Nit 2: CHECKs are not really a good tool in tests. Why not return false and let
the ASSERT() wrapped around this call catch the failure?

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:206:
SigninManagerFactory::GetForProfile(browser()->profile());
Nit: #include "chrome/browser/ui/browser.h"

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:276: //
Signing out on Chrome OS doesn't drop the policy caches.
What do you mean by signing out on Chrome OS? You cannot sign out of the browser
on that platform.

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.h (right):

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.h:95: // Deletes all
the cached components policy.
Nit: s/components/component/ parses better IMHO

[Joao da Silva, 2013-12-03 09:02:30]

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc (right):

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:88:
DCHECK(!value.empty());
On 2013/12/02 18:08:46, bartfab wrote:
> Nit 1: #include "base/logging.h"
> Nit 2: CHECKs are not really a good tool in tests. Why not return false and
let
> the ASSERT() wrapped around this call catch the failure?

Right, this was just a lazy copy/paste from resource_cache.cc :-) Done.

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:206:
SigninManagerFactory::GetForProfile(browser()->profile());
On 2013/12/02 18:08:46, bartfab wrote:
> Nit: #include "chrome/browser/ui/browser.h"

Done.

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc:276: //
Signing out on Chrome OS doesn't drop the policy caches.
On 2013/12/02 18:08:46, bartfab wrote:
> What do you mean by signing out on Chrome OS? You cannot sign out of the
browser
> on that platform.

Expanded this comment.

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
File chrome/browser/policy/cloud/component_cloud_policy_service.h (right):

https://codereview.chromium.org/98433003/diff/20001/chrome/browser/policy/clo...
chrome/browser/policy/cloud/component_cloud_policy_service.h:95: // Deletes all
the cached components policy.
On 2013/12/02 18:08:46, bartfab wrote:
> Nit: s/components/component/ parses better IMHO

Done.

[commit-bot: I haz the power, 2013-12-03 09:30:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/98433003/40001

[commit-bot: I haz the power, 2013-12-03 12:57:13]

Change committed as 238381