android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 984273002: Move onConsoleMessage implementation to chromium layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 984273002: Move onConsoleMessage implementation to chromium layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('K') | « android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index 8a32cc56c62bc0a5dd4c35e9e7686d58aa36e842..156d90fa3473017a720ac0256f827d670a9c5d04 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -117,8 +117,12 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {

break;

}

- return mContentsClient.onConsoleMessage(

+ boolean result = mContentsClient.onConsoleMessage(

new ConsoleMessage(message, sourceId, lineNumber, messageLevel));

+ if (result && message != null && message.startsWith("[blocked]")) {

+ Log.e(TAG, "Blocked URL: " + message);

+ }

+ return result;

}

@Override