Move onConsoleMessage implementation to chromium layer

Move onConsoleMessage implementation to chromium layer

Simple move of small chucnk of code out of glue layer.

BUG=464491
Committed: https://crrev.com/7b41c6561705c1645d65313d116f35c582bd6247
Cr-Commit-Position: refs/heads/master@{#319726}

[boliu, 2015-03-07 02:19:53]

boliu@chromium.org changed reviewers:
+ sgurun@chromium.org

[boliu, 2015-03-07 02:19:53]

it's a tiny one!

[sgurun-gerrit only, 2015-03-09 16:41:37]

https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(right):

https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:389:
result = false;
simply return false here and drop result. you can even drop else.

[boliu, 2015-03-09 16:46:05]

https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
File
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
(right):

https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:389:
result = false;
On 2015/03/09 16:41:37, sgurun wrote:
> simply return false here and drop result. you can even drop else. 

Actually I should keep the old structure. So s/return/result =/ above instead.

[sgurun-gerrit only, 2015-03-09 16:59:40]

On 2015/03/09 16:46:05, boliu wrote:
>
https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
> File
>
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
> (right):
> 
>
https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
>
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:389:
> result = false;
> On 2015/03/09 16:41:37, sgurun wrote:
> > simply return false here and drop result. you can even drop else. 
> 
> Actually I should keep the old structure. So s/return/result =/ above instead.

why, Is it to prevent merge conflicts?

lgtm

[boliu, 2015-03-09 17:02:26]

On 2015/03/09 16:59:40, sgurun wrote:
> On 2015/03/09 16:46:05, boliu wrote:
> >
>
https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
> > File
> >
>
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/984273002/diff/1/android_webview/glue/java/sr...
> >
>
android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java:389:
> > result = false;
> > On 2015/03/09 16:41:37, sgurun wrote:
> > > simply return false here and drop result. you can even drop else. 
> > 
> > Actually I should keep the old structure. So s/return/result =/ above
instead.
> 
> why, Is it to prevent merge conflicts?

No strong reason. It's not part of this refactor. Also there's a few other
places that uses the same pattern, so I guess also to stay consistent.

> 
> lgtm

[boliu, 2015-03-09 20:17:05]

cts WebChromeClientTest all passes

[boliu, 2015-03-09 20:17:10]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-03-09 20:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984273002/20001

[commit-bot: I haz the power, 2015-03-09 20:45:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 20:49:46]

Patchset 2 (id:??) landed as
https://crrev.com/7b41c6561705c1645d65313d116f35c582bd6247
Cr-Commit-Position: refs/heads/master@{#319726}