Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 984173003: Autofill - share some strings between desktop and Android. (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill - share some strings between desktop and Android. BUG=none Committed: https://crrev.com/e8da849da398fb77ea4e053625a242445ed7614d Cr-Commit-Position: refs/heads/master@{#319571}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M chrome/android/java/res/layout/autofill_card_unmask_prompt.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 12 (4 generated)
Evan Stade
5 years, 9 months ago (2015-03-07 00:18:05 UTC) #2
newt (away)
lgtm after comment https://codereview.chromium.org/984173003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/984173003/diff/1/chrome/app/generated_resources.grd#newcode11207 chrome/app/generated_resources.grd:11207: + <message name="IDS_CARD_UNMASK_CONFIRM_BUTTON" desc="Text for button ...
5 years, 9 months ago (2015-03-07 00:40:55 UTC) #3
Evan Stade
https://codereview.chromium.org/984173003/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/984173003/diff/1/chrome/app/generated_resources.grd#newcode11207 chrome/app/generated_resources.grd:11207: + <message name="IDS_CARD_UNMASK_CONFIRM_BUTTON" desc="Text for button that confirms the ...
5 years, 9 months ago (2015-03-07 00:55:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984173003/1
5 years, 9 months ago (2015-03-07 00:57:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) mac_chromium_compile_dbg_ng on ...
5 years, 9 months ago (2015-03-07 02:58:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984173003/1
5 years, 9 months ago (2015-03-08 01:21:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 03:52:48 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 03:53:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8da849da398fb77ea4e053625a242445ed7614d
Cr-Commit-Position: refs/heads/master@{#319571}

Powered by Google App Engine
This is Rietveld 408576698