Issue 984163002: Refactoring mojo android init_library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 984163002: Refactoring mojo android init_library (Closed)

Created:
5 years, 9 months ago by michaelbai

Modified:
5 years, 9 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Refactoring mojo android init_library Make it to use base::android::OnJNIOnLoad interface. BUG=447393 Committed: https://crrev.com/fe321fca86e26ad616c7cb9f5b303394f22b8bb5 Cr-Commit-Position: refs/heads/master@{#319700}

Patch Set 1 #

Patch Set 2 : fix test #

Patch Set 3 : #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
	M	mojo/android/javatests/init_library.cc	View	1 2	2 chunks	+18 lines, -17 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984163002/40001

5 years, 9 months ago (2015-03-09 17:58:53 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-09 18:41:29 UTC) #7

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/fe321fca86e26ad616c7cb9f5b303394f22b8bb5
Cr-Commit-Position: refs/heads/master@{#319700}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages