Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 984153004: SkyShell DCHECKs on startup sometimes (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

SkyShell DCHECKs on startup sometimes Sometimes we try to draw a 0x0 picture. We shouldn't bother trying to turn a 0x0 picture into actual pixels. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/117577aaf19ec9da66b2ae15a1a51e6c23e51309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M sky/shell/gpu/rasterizer.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-09 23:07:30 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-09 23:08:55 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-09 23:19:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
117577aaf19ec9da66b2ae15a1a51e6c23e51309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698