Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 984113004: cc: Add raster_enabled setting (Closed)

Created:
5 years, 9 months ago by enne (OOO)
Modified:
5 years, 9 months ago
Reviewers:
danakj, reveman
CC:
reveman, boliu, cc-bugs_chromium.org, chromium-reviews, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@implsidepaintinglayout
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add raster_enabled setting In order to support impl-side painting plus an embedder without a message loop, cc needs a setting to disable raster. Rastering with impl-side painting requires a task runner (and DCHECKs this). This setting notifies cc that there's no need for a tile manager. Thankfully, tile manager is already considered optional in almost all contexts, and so just a few more callsites needed to be cleaned up to fix a few crashes. With this patch, all cc unittests pass with impl-side painting on by default. Committed: https://crrev.com/bdb6fd2037025923c986d1e3552cf9f99a634554 Cr-Commit-Position: refs/heads/master@{#319840}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -15 lines) Patch
M cc/layers/picture_layer.cc View 1 chunk +15 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +1 line, -0 lines 1 comment Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
enne (OOO)
https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_host_unittest_no_message_loop.cc File cc/trees/layer_tree_host_unittest_no_message_loop.cc (right): https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_host_unittest_no_message_loop.cc#newcode107 cc/trees/layer_tree_host_unittest_no_message_loop.cc:107: settings.raster_enabled = false; This test does a full composite ...
5 years, 9 months ago (2015-03-06 22:07:00 UTC) #2
enne (OOO)
+reveman
5 years, 9 months ago (2015-03-10 00:28:10 UTC) #4
reveman
https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc File cc/trees/layer_tree_settings.cc (right): https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc#newcode18 cc/trees/layer_tree_settings.cc:18: raster_enabled(true), how is raster done when this is false, ...
5 years, 9 months ago (2015-03-10 04:01:51 UTC) #5
enne (OOO)
https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc File cc/trees/layer_tree_settings.cc (right): https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc#newcode18 cc/trees/layer_tree_settings.cc:18: raster_enabled(true), On 2015/03/10 04:01:51, reveman wrote: > how is ...
5 years, 9 months ago (2015-03-10 04:05:24 UTC) #6
reveman
lgtm https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc File cc/trees/layer_tree_settings.cc (right): https://codereview.chromium.org/984113004/diff/1/cc/trees/layer_tree_settings.cc#newcode18 cc/trees/layer_tree_settings.cc:18: raster_enabled(true), On 2015/03/10 04:05:24, enne wrote: > On ...
5 years, 9 months ago (2015-03-10 04:06:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984113004/1
5 years, 9 months ago (2015-03-10 04:17:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 06:02:09 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bdb6fd2037025923c986d1e3552cf9f99a634554 Cr-Commit-Position: refs/heads/master@{#319840}
5 years, 9 months ago (2015-03-10 06:02:41 UTC) #11
danakj
5 years, 9 months ago (2015-03-10 16:54:46 UTC) #12
Message was sent while issue was closed.
lgtm 2

Powered by Google App Engine
This is Rietveld 408576698