Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 984083002: Include the LSan header directly in base/debug/leak_annotations.h. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include the LSan header directly in base/debug/leak_annotations.h. BUG=325925 R=thakis@chromium.org Committed: https://crrev.com/6fded47ceb1f521d9b0a36cc1a1c89e54a2c7746 Cr-Commit-Position: refs/heads/master@{#319917}

Patch Set 1 #

Patch Set 2 : add back the scoped disabler definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M base/debug/leak_annotations.h View 1 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
earthdok
5 years, 9 months ago (2015-03-06 17:20:29 UTC) #1
Nico
lgtm
5 years, 9 months ago (2015-03-06 17:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984083002/1
5 years, 9 months ago (2015-03-06 17:31:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984083002/20001
5 years, 9 months ago (2015-03-06 18:17:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-06 23:46:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984083002/20001
5 years, 9 months ago (2015-03-10 14:15:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 17:48:53 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 17:49:35 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fded47ceb1f521d9b0a36cc1a1c89e54a2c7746
Cr-Commit-Position: refs/heads/master@{#319917}

Powered by Google App Engine
This is Rietveld 408576698