Add more tests for manual and auto subframe navigation classifications.

Add more tests for manual and auto subframe navigation classifications.

BUG=369661
TEST=no code changes; this adds new tests

Committed: https://crrev.com/558cf1295dd159d2c407555e003487c689e458bc
Cr-Commit-Position: refs/heads/master@{#319527}

[Avi (use Gerrit), 2015-03-06 20:16:23]

avi@chromium.org changed reviewers:
+ creis@chromium.org

[Avi (use Gerrit), 2015-03-06 20:16:24]

I can't believe I forgot these two.

[Charlie Reis, 2015-03-06 22:06:30]

Hooray for more tests!  These LGTM.

Others to consider:
 - In page navigation (#foo)
 - Client redirect

https://codereview.chromium.org/984063003/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/984063003/diff/20001/content/browser/frame_ho...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:390:
EXPECT_EQ(ui::PAGE_TRANSITION_AUTO_SUBFRAME, capturer.transition_type());
Is there anything we can check here and in location.replace that the entry was
actually replaced?  Or is that beyond the scope of this test, which focuses on
the classification?

[Avi (use Gerrit), 2015-03-06 22:19:02]

I will add in-page hash nav; as for client-redirect, that's going to need me to
be clever, and I want to get the low-hanging fruit first.

https://codereview.chromium.org/984063003/diff/20001/content/browser/frame_ho...
File content/browser/frame_host/navigation_controller_impl_browsertest.cc
(right):

https://codereview.chromium.org/984063003/diff/20001/content/browser/frame_ho...
content/browser/frame_host/navigation_controller_impl_browsertest.cc:390:
EXPECT_EQ(ui::PAGE_TRANSITION_AUTO_SUBFRAME, capturer.transition_type());
On 2015/03/06 22:06:30, Charlie Reis wrote:
> Is there anything we can check here and in location.replace that the entry was
> actually replaced?  Or is that beyond the scope of this test, which focuses on
> the classification?

I was kinda assuming things actually worked here, and was focusing on the
classification.

[Avi (use Gerrit), 2015-03-06 22:19:13]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-03-06 22:19:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984063003/20001

[Charlie Reis, 2015-03-06 22:21:59]

On 2015/03/06 22:19:02, Avi wrote:
> I will add in-page hash nav; as for client-redirect, that's going to need me
to
> be clever, and I want to get the low-hanging fruit first.

Sounds good.  Client redirect shouldn't be too hard if you create a file like
this:
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/data/...

[Avi (use Gerrit), 2015-03-06 22:28:46]

On 2015/03/06 22:21:59, Charlie Reis wrote:
> On 2015/03/06 22:19:02, Avi wrote:
> > I will add in-page hash nav; as for client-redirect, that's going to need me
> to
> > be clever, and I want to get the low-hanging fruit first.
> 
> Sounds good.  Client redirect shouldn't be too hard if you create a file like
> this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/test/data/...

I'm not worrying about the file, I worry about the test code to catch two
commits. I'm sure it's only mildly tricky, but I want to get the easy ones out
of the way first.

[Avi (use Gerrit), 2015-03-06 23:25:56]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2015-03-06 23:26:01]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-03-06 23:26:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984063003/20001

[Avi (use Gerrit), 2015-03-06 23:31:52]

The CQ bit was unchecked by avi@chromium.org

[Avi (use Gerrit), 2015-03-06 23:32:32]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2015-03-06 23:34:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984063003/20001

[commit-bot: I haz the power, 2015-03-06 23:41:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-06 23:42:24]

Patchset 2 (id:??) landed as
https://crrev.com/558cf1295dd159d2c407555e003487c689e458bc
Cr-Commit-Position: refs/heads/master@{#319527}