[bindings] Remove custom binding usage from CryptoKey.idl

[bindings] Remove custom binding usage from CryptoKey.idl

As part of custom binding removal efforts, this CL will eliminate the usage of
custom binding for CryptoKey.algorithm attribute.

R=jl@opera.com, haraken@chromium.org, eroman@chromium.org

BUG=345519
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191697

[vivekg, 2015-03-08 09:13:46]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-03-08 09:13:47]

PTAL thanks.

[eroman, 2015-03-08 20:10:55]

lgtm

[vivekg, 2015-03-09 04:07:30]

haraken@, jl@: awaiting your approval.

[haraken, 2015-03-09 04:13:45]

LGTM

https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
File Source/modules/crypto/CryptoKey.cpp (right):

https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
Source/modules/crypto/CryptoKey.cpp:102: DictionaryBuilder(ScriptState*
scriptState)

Add explicit.

https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
Source/modules/crypto/CryptoKey.cpp:135: ScriptState* m_scriptState;

Not related to your CL, a safer way to use a ScriptState is to hold it using a
RefPtr. (In this particular case, a raw pointer would be OK because the
DictionaryBuilder is used only on stack.)

ScriptState* => RefPtr<ScriptState>

[vivekg, 2015-03-11 11:23:46]

On 2015/03/09 04:13:45, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
> File Source/modules/crypto/CryptoKey.cpp (right):
> 
>
https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
> Source/modules/crypto/CryptoKey.cpp:102: DictionaryBuilder(ScriptState*
> scriptState)
> 
> Add explicit.
> 
>
https://codereview.chromium.org/984053003/diff/1/Source/modules/crypto/Crypto...
> Source/modules/crypto/CryptoKey.cpp:135: ScriptState* m_scriptState;
> 
> Not related to your CL, a safer way to use a ScriptState is to hold it using a
> RefPtr. (In this particular case, a raw pointer would be OK because the
> DictionaryBuilder is used only on stack.)
> 
> ScriptState* => RefPtr<ScriptState>

Thanks, done.

[vivekg, 2015-03-11 11:23:54]

The CQ bit was checked by vivekg@chromium.org

[vivekg, 2015-03-11 11:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/984053003/#ps20001 (title:
"Patch for landing!")

[commit-bot: I haz the power, 2015-03-11 11:24:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/984053003/20001

[commit-bot: I haz the power, 2015-03-11 12:43:27]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191697