Issue 98403006: Updateing ASAN stub with new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98403006: Updateing ASAN stub with new API (Closed)

Created:
7 years ago by yunlian

Modified:
7 years ago

Reviewers:
craigdh, Alexander Potapenko, kcc2, kkania, (unused - use chromium)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Updateing ASAN stub with new API Clang r192869 adds several ASAN functions. BUG=chromium:326257 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239660

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	chrome/test/pyautolib/asan_stub.c	View		1 chunk	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yunlian

Can you take a look at this CL. This is blocking clang update for ChromeOS. ...

7 years ago (2013-12-06 22:02:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/98403006/1

7 years ago (2013-12-09 22:10:29 UTC) #3

Alexander Potapenko

7 years ago (2013-12-10 08:35:37 UTC) #5

Message was sent while issue was closed.

Is this stub still being used? Let me remind that the code that links with it is
actually not being tested. Also, I'd suggest to add CHECK(0) to the API
functions implementations to make sure they're never invoked.
(sorry for the late reply)

Expand Messages | Collapse Messages