Disable kSSizeMaxConst COMPILE_ASSERT() for Android / Mac / IOS

base/strings/safe_sprintf.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/safe_sprintf.h"
 
 #include <limits>
 
 #if !defined(NDEBUG)
 // In debug builds, we use RAW_CHECK() to print useful error messages, if
@@ skipping 90 matching lines @@
   // |buffer| is caller-allocated storage that SafeSPrintf() writes to. It
   // has |size| bytes of writable storage. It is the caller's responsibility
   // to ensure that the buffer is at least one byte in size, so that it fits
   // the trailing NUL that will be added by the destructor. The buffer also
   // must be smaller or equal to kSSizeMax in size.
   Buffer(char* buffer, size_t size)
       : buffer_(buffer),
         size_(size - 1),  // Account for trailing NUL byte
         count_(0) {
 // This test should work on all C++11 compilers, but apparently something is
-// not working on all versions of clang just yet (e.g. on Mac, IOS, and
-// Android). We are conservative and exclude all of clang for the time being.
+// not working on all versions of clang / gcc just yet (e.g. on Mac, IOS, and
+// Android). We exclude those platforms for now.
 // TODO(markus): Check if this restriction can be lifted.
-#if __cplusplus >= 201103 && !defined(__clang__)
+#if __cplusplus >= 201103 && !defined(OS_ANDROID) && !defined(OS_MACOSX) && !defined(OS_IOS)
     COMPILE_ASSERT(kSSizeMaxConst == std::numeric_limits<ssize_t>::max(),

[Inactive, 2013/12/06 22:18:10]

Note that on Linux desktop, gcc does complain about comparison between signed
and unsigned integers though :(

[Nico, 2013/12/06 22:21:45]

It should be safe to cast std::numeric_limits<ssize_t>::max() to size_t, no?

                    kSSizeMax_is_the_max_value_of_an_ssize_t);
 #endif
     DEBUG_CHECK(size > 0);
     DEBUG_CHECK(size <= kSSizeMax);
   }
 
   ~Buffer() {
     // The code calling the constructor guaranteed that there was enough space
     // to store a trailing NUL -- and in debug builds, we are actually
     // verifying this with DEBUG_CHECK()s in the constructor. So, we can
@@ skipping 546 matching lines @@
     DEBUG_CHECK(src[0] != '%' || src[1] == '%');
     if (src[0] == '%' && src[1] == '%') {
       ++src;
     }
   }
   return buffer.GetCount();
 }
 
 }  // namespace strings
 }  // namespace base