Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 984023003: Avoid loosing of the display mode value (Closed)

Created:
5 years, 9 months ago by Mikhail
Modified:
5 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid loosing of the display mode value Before this change WebViewImpl relied on FrameView to store the display mode value. It caused problems as FrameView can be re-created many times during a single WebView object life-cycle (for example FrameView is re-created during navigation). Now WebViewImpl stores the display mode itself and the stored value is passed to all the newly created FrameViews. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kenneth.r.christiansen
lgtm
5 years, 9 months ago (2015-03-06 15:51:28 UTC) #2
kenneth.r.christiansen
lgtm
5 years, 9 months ago (2015-03-11 16:58:52 UTC) #3
Mike West
LGTM, sorry for the delay. :(
5 years, 9 months ago (2015-03-12 04:11:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/984023003/1
5 years, 9 months ago (2015-03-12 07:14:32 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 08:53:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191763

Powered by Google App Engine
This is Rietveld 408576698