Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 983973005: Add an assert that we don't schedule a render during render (Closed)

Created:
5 years, 9 months ago by eseidel
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, Hixie
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an assert that we don't schedule a render during render In production I added an early return. I don't bother to log in production since no one is looking at the log anyway. Unfortunately this currently only fires when using a debug build we should fix our Release build to have a checked-mode option or consider hacks like having all localhost urls enable checked mode, etc. R=ianh@google.com, rafaelw@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/356d3b720e51a626acf75626ae738648a2b171b6

Patch Set 1 #

Patch Set 2 : Don't die in production #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M sky/framework/fn.dart View 1 1 chunk +20 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 9 months ago (2015-03-06 18:38:27 UTC) #1
Hixie
lgtm
5 years, 9 months ago (2015-03-06 18:42:35 UTC) #3
eseidel
5 years, 9 months ago (2015-03-06 18:42:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
356d3b720e51a626acf75626ae738648a2b171b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698