Source/core/css/FontLoader.cpp - Issue 983973004: Provide user friendly messages for OTS parsing of fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontLoader.cpp

Issue 983973004: Provide user friendly messages for OTS parsing of fonts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase patch Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/FontLoader.cpp

diff --git a/Source/core/css/FontLoader.cpp b/Source/core/css/FontLoader.cpp

index 94aeca097a4bce6676ccde1f59c14df273576006..da59f1bee607d82e68d96431f877d6d991e6c35f 100644

--- a/Source/core/css/FontLoader.cpp

+++ b/Source/core/css/FontLoader.cpp

@@ -98,6 +98,8 @@ void FontLoader::didFailToDecode(FontResource* fontResource)

// See crbug.com/97467

if (m_fontSelector && m_fontSelector->document())

m_fontSelector->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, WarningMessageLevel, "Failed to decode downloaded font: " + fontResource->url().elidedString()));

+ if (fontResource->otsParsingMessage().length() > 1)

+ m_fontSelector->document()->addConsoleMessage(ConsoleMessage::create(OtherMessageSource, WarningMessageLevel, "OTS parsing error: " + fontResource->otsParsingMessage()));

}

#if !ENABLE(OILPAN)

« no previous file with comments | « Source/core/css/FontFace.cpp ('k') | Source/core/fetch/FontResource.h » ('j') | no next file with comments »