Source/core/css/FontFace.cpp - Issue 983973004: Provide user friendly messages for OTS parsing of fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/FontFace.cpp

Issue 983973004: Provide user friendly messages for OTS parsing of fonts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Correcting Method call Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/FontFace.cpp

diff --git a/Source/core/css/FontFace.cpp b/Source/core/css/FontFace.cpp

index 3760985540155e93f8177cc8b95426d6acf9fcb2..f9313d9c9e132648d41405014945bd7674342204 100644

--- a/Source/core/css/FontFace.cpp

+++ b/Source/core/css/FontFace.cpp

@@ -552,7 +552,7 @@ void FontFace::initCSSFontFace(const unsigned char* data, unsigned size)

return;

RefPtr<SharedBuffer> buffer = SharedBuffer::create(data, size);

- OwnPtrWillBeRawPtr<BinaryDataFontFaceSource> source = adoptPtrWillBeNoop(new BinaryDataFontFaceSource(buffer.get()));

+ OwnPtrWillBeRawPtr<BinaryDataFontFaceSource> source = adoptPtrWillBeNoop(new BinaryDataFontFaceSource(buffer.get(), m_otsParseMessage));

if (source->isValid())

setLoadStatus(Loaded);

else

« no previous file with comments | « Source/core/css/FontFace.h ('k') | Source/core/css/FontLoader.cpp » ('j') | Source/platform/fonts/FontCustomPlatformData.cpp » ('J')