Source/core/fetch/FontResource.cpp - Issue 983973004: Provide user friendly messages for OTS parsing of fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/FontResource.cpp

Issue 983973004: Provide user friendly messages for OTS parsing of fonts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comment fixes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/fetch/FontResource.h ('k') | Source/platform/fonts/FontCustomPlatformData.h » ('j') | Source/platform/fonts/FontCustomPlatformData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fetch/FontResource.cpp

diff --git a/Source/core/fetch/FontResource.cpp b/Source/core/fetch/FontResource.cpp

index e2bd3a81aeb0f138c17cd0111ae2dc349aada25d..0e68fdd1d0c3e782a2b15de048b014a31717bd4f 100644

--- a/Source/core/fetch/FontResource.cpp

+++ b/Source/core/fetch/FontResource.cpp

@@ -122,7 +122,7 @@ bool FontResource::ensureCustomFontData()

{

if (!m_fontData && !errorOccurred() && !isLoading()) {

if (m_data)

- m_fontData = FontCustomPlatformData::create(m_data.get());

+ m_fontData = FontCustomPlatformData::create(m_data.get(), m_otsParsingMessage);

if (m_fontData) {

recordPackageFormatHistogram(packageFormatOf(m_data.get()));

« no previous file with comments | « Source/core/fetch/FontResource.h ('k') | Source/platform/fonts/FontCustomPlatformData.h » ('j') | Source/platform/fonts/FontCustomPlatformData.cpp » ('J')