Source/platform/fonts/FontCustomPlatformData.h - Issue 983973004: Provide user friendly messages for OTS parsing of fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/FontCustomPlatformData.h

Issue 983973004: Provide user friendly messages for OTS parsing of fonts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code update for test expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/fetch/FontResource.cpp ('k') | Source/platform/fonts/FontCustomPlatformData.cpp » ('j') | Source/platform/fonts/FontCustomPlatformData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/FontCustomPlatformData.h

diff --git a/Source/platform/fonts/FontCustomPlatformData.h b/Source/platform/fonts/FontCustomPlatformData.h

index 403716950256be24a80281c975288c0c3d9af47a..141f915f5440d0645eeb4bc40a4064c16eb1ad54 100644

--- a/Source/platform/fonts/FontCustomPlatformData.h

+++ b/Source/platform/fonts/FontCustomPlatformData.h

@@ -49,7 +49,7 @@ class SharedBuffer;

class PLATFORM_EXPORT FontCustomPlatformData {

WTF_MAKE_NONCOPYABLE(FontCustomPlatformData);

public:

- static PassOwnPtr<FontCustomPlatformData> create(SharedBuffer*);

+ static PassOwnPtr<FontCustomPlatformData> create(SharedBuffer*, String& otsParseMessage);

~FontCustomPlatformData();

FontPlatformData fontPlatformData(float size, bool bold, bool italic, FontOrientation = FontOrientation::Horizontal);

« no previous file with comments | « Source/core/fetch/FontResource.cpp ('k') | Source/platform/fonts/FontCustomPlatformData.cpp » ('j') | Source/platform/fonts/FontCustomPlatformData.cpp » ('J')