Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: ui/compositor/layer_owner.cc

Issue 983933002: Reset the root layer on the compositor when recreating a root layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a test expectation that the compositor's root_layer is updated correctly during RecreateLayer. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/compositor/layer_owner.h" 5 #include "ui/compositor/layer_owner.h"
6 6
7 #include "ui/compositor/layer_owner_delegate.h" 7 #include "ui/compositor/layer_owner_delegate.h"
8 8
9 namespace ui { 9 namespace ui {
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 // Migrate all the child layers over to the new layer. Copy the list because 59 // Migrate all the child layers over to the new layer. Copy the list because
60 // the items are removed during iteration. 60 // the items are removed during iteration.
61 std::vector<ui::Layer*> children_copy = old_layer->children(); 61 std::vector<ui::Layer*> children_copy = old_layer->children();
62 for (std::vector<ui::Layer*>::const_iterator it = children_copy.begin(); 62 for (std::vector<ui::Layer*>::const_iterator it = children_copy.begin();
63 it != children_copy.end(); 63 it != children_copy.end();
64 ++it) { 64 ++it) {
65 ui::Layer* child = *it; 65 ui::Layer* child = *it;
66 new_layer->Add(child); 66 new_layer->Add(child);
67 } 67 }
68 68
69 // If old_layer was the layer tree root then we need to move the Compositor
70 // over to the new root.
71 const bool is_root = !old_layer->parent();
72 if (is_root && old_layer->GetCompositor())
73 old_layer->GetCompositor()->SetRootLayer(new_layer);
74
69 // Install the delegate last so that the delegate isn't notified as we copy 75 // Install the delegate last so that the delegate isn't notified as we copy
70 // state to the new layer. 76 // state to the new layer.
71 new_layer->set_delegate(old_delegate); 77 new_layer->set_delegate(old_delegate);
72 78
73 if (layer_owner_delegate_) 79 if (layer_owner_delegate_)
74 layer_owner_delegate_->OnLayerRecreated(old_layer.get(), new_layer); 80 layer_owner_delegate_->OnLayerRecreated(old_layer.get(), new_layer);
75 81
76 return old_layer.Pass(); 82 return old_layer.Pass();
77 } 83 }
78 84
79 void LayerOwner::DestroyLayer() { 85 void LayerOwner::DestroyLayer() {
80 layer_ = NULL; 86 layer_ = NULL;
81 layer_owner_.reset(); 87 layer_owner_.reset();
82 } 88 }
83 89
84 bool LayerOwner::OwnsLayer() const { 90 bool LayerOwner::OwnsLayer() const {
85 return !!layer_owner_; 91 return !!layer_owner_;
86 } 92 }
87 93
88 } // namespace ui 94 } // namespace ui
OLDNEW
« no previous file with comments | « no previous file | ui/compositor/layer_owner_unittest.cc » ('j') | ui/compositor/layer_owner_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698